Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2022-06-02T12:17:36Z
----------------------------------------------------------------

With the watermark below you can get rid of the print.

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2022-06-02T12:17:37Z
----------------------------------------------------------------

Is there a red line undeneath the black ones? seems really faint, not sure what in the code would cause that.

conorhassan commented on 2022-06-02T13:05:06Z
----------------------------------------------------------------

I agree that there looks like there is some faint colouring lines somewhere within the black ones, but there is nothing? there in the code that I can see.

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2022-06-02T12:17:37Z
----------------------------------------------------------------

aesara.tensor -> at

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2022-06-02T12:17:38Z
----------------------------------------------------------------

Fix span issue.

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2022-06-02T12:17:39Z
----------------------------------------------------------------

Try with nu=3.

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2022-06-02T12:17:39Z
----------------------------------------------------------------

legend missing.

I'd probably just remove this plot because it's a bit redundant.

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2022-06-02T12:17:40Z
----------------------------------------------------------------

if you move the plot of the true regression further down and decrease alpha the red line should be more visible.

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2022-06-02T12:17:41Z
----------------------------------------------------------------

The next post will be about logistic regression in PyMC and what the posterior and oatmeal have in common.

Can you remove this?

To fix pre-commit you can try to remove the corresponding myst file of the same NB and that way trigger it being recreated. Make sure to also include that file in your commit.

I agree that there looks like there is some faint colouring lines somewhere within the black ones, but there is nothing? there in the code that I can see.

View entire conversation on ReviewNB

I think the tests are failing because of the internal links to other notebook. These need to be updated using myst references, see
https://docs.pymc.io/en/latest/contributing/jupyter_style.html#myst-guidelines
So following the link through takes you to here https://docs.readthedocs.io/en/stable/guides/cross-referencing-with-sphinx.html#the-doc-role so I think the links needs to be replaced with this

{doc}`my_doc_name`

where my_doc_name is the filename of the notebook and should correspond to the (factor_analysis)= (for example) in the first code cell of the target notebook

We currently have 3 PRs open for this same notebook: #356, #445, #451. And I am not sure how to go about this, git conflicts on notebooks are a nightmare. I might try to merge the myst and then update the notebook from it which might happen in a 4th PR overriding the current 3. I will take a look and work on this next week. Thank you all for the PRs, I'll make sure at the very least you are listed as co-author in the merged PR.

@conorhassan
Can you send me the email address you use for GitHub, so @OriolAbril can add you as a co-author on the GLM-robust notebook? (can send to me on Slack)

Superseded by #472